Merged
Conversation
Julow
approved these changes
Mar 11, 2022
Collaborator
Julow
left a comment
There was a problem hiding this comment.
That's better !
But I find it ugly to have both the blue border and the shadow, let's remove the border.
src/odoc/etc/odoc.css
Outdated
| .spec.type .record > .def-doc, .spec.type .variant > .def-doc { | ||
| min-width:50%; | ||
| padding-left: 22px; | ||
| padding-left: 18px; |
Collaborator
There was a problem hiding this comment.
If you remove the blue border, a smaller padding would be better: (the same as .spec)
Suggested change
| padding-left: 18px; | |
| padding: 0.35em 0.5em; |
Signed-off-by: Paul-Elliot <peada@free.fr>
570b4c6 to
ab3365d
Compare
Drup
approved these changes
Mar 15, 2022
Contributor
Drup
left a comment
There was a problem hiding this comment.
I agree, this is much better. 👍
|
Could the doc comments be consistently placed below the constructor? I find it awkward to read when some of the comments are below and some of them are off to the right. |
Member
mseri
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Dec 13, 2022
CHANGES: Additions - New unstable option `--as-json` for the HTML renderer that emits HTML fragments (preamble, content) together with metadata (table of contents, breadcrumbs, whether katex is used) in JSON format. (@sabine, ocaml/odoc#908) - New maths support via `{m ... }` and `{math ... }` tags. (@giltho, @gpetiot, ocaml/odoc#886) - Various optimisations (@jonludlam, ocaml/odoc#870, ocaml/odoc#883) - Better handling of alerts and deprecation notices. (@panglesd, ocaml/odoc#828) - Handle language tags on code blocks (@Julow, ocaml/odoc#848) Bugfixes - Shadowing issues (@jonludlam, ocaml/odoc#853) - Layout fixes and improvements (@panglesd, ocaml/odoc#832, ocaml/odoc#839, ocaml/odoc#847) - Handle comments on class constraints and inherit (@Julow, ocaml/odoc#844) - Disable the missing root warning (@jonludlam, ocaml/odoc#881)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the css introduced in #830:
It find it more logical that odoc comments always have a
--main-backgroundcolor, even if they are inside aspec(with background--spec-summary-background).I think it makes it easier to read large record fields with many comments attached to fields.
Compare the two images:
with
You can find complete examples of the old style and new style for this file.
(Maybe the thin blue bar could be removed now that the background is white... what do you think?)