Closed
Conversation
Contributor
|
@def-lkb Arf, I was bound to miss some of them. Thanks! |
Contributor
|
@def-lkb I think it would be best to rebase on #487, just to make sure everything is alright and ease merging. You may have to adjust the tests too .. |
Contributor
Author
|
No time right now. Kthxbye :) |
Contributor
|
Thanks! Fixed the testsuite, rebased and pushed to 4.03. |
EduardoRFS
pushed a commit
to esy-ocaml/ocaml
that referenced
this pull request
May 17, 2021
Replace caml_modify_field with caml_modify
mshinwell
added a commit
to mshinwell/ocaml
that referenced
this pull request
Jun 28, 2021
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
May 24, 2022
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
* Use polymorphic variants * Add Margin.Top * Use Margin.Top * Cleanup React.string * Inline some polymorphic variants * Move TitleHeading.callToAction to CallToAction module * Use CallToAction.Simple * Add example of CallToAction.Simple to storybook * Capitalize some polymorphic variants * Capitalize Route polymorphic variants * Remove Link module alias * Open Import everywhere * Remove trailing unit args from @react.components
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
Co-authored-by: tmattio <tmattio@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #498 rebased on 4.03.
I added a few more corrections.
Fix: the github pull request was made against the wrong base. Sorry for the noise.