Attributes sometimes dropped by parser#498
Closed
let-def wants to merge 3 commits intoocaml:trunkfrom
Closed
Conversation
Contributor
|
Thanks! This should probably go in 4.03. Can you rebase on that branch (I think you need to open a new PR)? |
Member
|
One more reason to use Menhir ( #292 ) as a parser generator... |
Member
|
Do we know which faulty refactoring it was? Can we check that all mistakes it introduced were covered? |
Contributor
Contributor
|
Indeed, adding |
Contributor
|
We should really enable more warnings in the compiler. I've started to work on it in this branch https://github.com/ocaml/ocaml/tree/enable_more_warnings and already found one probable bug in the type-checker. |
lukemaurer
pushed a commit
to lukemaurer/ocaml
that referenced
this pull request
Jun 25, 2021
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
Sep 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These look like mistakes introduced during refactoring.
I am not sure what is the exact syntax allowed for attributes, I just used what seemed obvious.