Merged
Conversation
Contributor
Author
|
@damiendoligez CI is happy now! |
Member
|
I hope this is not going to conflict with #477 ... |
Contributor
|
It should be fine, we're not touching the same rules. |
Contributor
Author
|
I rebased on top of @trefis's patch, no conflicts, tests still pass. |
Closed
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
May 24, 2022
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
Tailwind 3.1.0 introduced the support for postcss-import in their standalone CLI. This allows us to revert part of ocaml/ocaml.org#354 and split our CSS file into multiple files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remake of #481, but to the right branch. Original text below
This is a fix for #342 (comment). I forgot class types, so here they are. I also fixed the order for shortcut/flags on class fields and added the relevant tests.
Note that the order for the
!flag on class fields is a bit irregular:and not
I think this is for the best. If anyone disagree, I can change it.
I also had to copy the trick used in the
method_rule to avoid a conflict in the grammar. As the TODO says, this part would benefit a lot from a little cleanup.