Closed
Conversation
Contributor
Author
|
@damiendoligez @gasche This should probably go inside 4.03 |
Contributor
Author
|
I don't understand the test failure, I can't reproduce them. Are they related ? It seems a bit unlikely. |
Contributor
|
Yeah, there's some backtrace-related failure that occurs only with flambda, showing a strange frame with no location information. It's on our list to look at. |
Member
|
@Drup As this is a bug fix, you should have made the PR against 4.03, not trunk. |
Contributor
Author
|
@damiendoligez Alright, sorry! Should I close this one ? |
Member
|
I guess so, yes, since github cannot redirect a PR. |
Merged
Merged
Keryan-dev
pushed a commit
to Keryan-dev/ocaml
that referenced
this pull request
Jun 21, 2021
Gbury
pushed a commit
to Gbury/ocaml
that referenced
this pull request
Jun 22, 2021
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
May 24, 2022
Currently, every type head caches its free names. This isn't helpful for alias types, since the free names of a `Simple.t` are trivial to produce on demand (it's usually just the simple itself). We can avoid this by only wrapping non-alias types in `With_cached_free_names.t`. Pleasingly, it so happens that largely all that's needed is to change ``` type 'head t = 'head Descr.t WCFN.t Or_unknown_or_bottom.t ``` to ``` type 'head t = 'head WCFN.t Descr.t Or_unknown_or_bottom.t ``` and commute a few function calls similarly.
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #342 (comment). I forgot class types, so here they are. I also fixed the order for shortcut/flags on class fields and added the relevant tests.
Note that the order for the
!flag on class fields is a bit irregular:and not
I think this is for the best. If anyone disagree, I can change it.
I also had to copy the trick used in the
method_rule to avoid a conflict in the grammar. As the TODO says, this part would benefit a lot from a little cleanup.cc @bobzhang