Conversation
|
Some existing warning numbers have been accidentally changed, we need to fix this. |
|
If you would like to read this diff, please instead pull the following branches from github.com/chambart: flambda_prereqs (= ocaml/trunk + outstanding GPRs) Then do e.g.: |
|
I will squash this branch when the other PR will be merged. This will make the diff obvious. |
|
Well, the diff should be obvious automatically as soon as the other PRs are merged. |
|
Yes, but a clean commit history would be really nice to have. 2016-01-15 14:08 GMT+00:00 Mark Shinwell notifications@github.com:
|
|
The commit history is an orthogonal issue, but yes, we can squash that. |
180c05e to
790ff2d
Compare
|
I've just squashed the patch, the history is still availableas in the branch https://github.com/chambart/ocaml-1/tree/flambda_merge_before_squash |
|
Any comments on this patch are welcome. |
|
Also, we will probably adjust some of the naming of command line arguments for inlining in flambda mode before the release. |
asmcomp/cmmgen.ml
Outdated
There was a problem hiding this comment.
This seems to be the only call to this function which is not protected by a check on flambda mode. Instead of doing the check inside the function, one could do it here to make it that nothing changes in non flambda mode.
790ff2d to
6b672ef
Compare
asmcomp/compilenv.ml
Outdated
There was a problem hiding this comment.
Where is this information recorded? I cannot find such a place in this diff.
There was a problem hiding this comment.
I'm currently cleaning the diff and that was part of some changes that were removed.
|
The native toplevel will keep getting broken by some other patch if we don't add it to the testsuite. Should I add that to this patch ? |
I agree with that assertion. But I think adding it to the testsuite is a separate concern than the one of this PR, so I would do another one. |
|
@damiendoligez, do you think that this is ready ? |
asmcomp/asmgen.ml
Outdated
There was a problem hiding this comment.
Is there a reason for the change from the previous symbol = Compilenv.make_symbol None to this one? (and current_unit_linkage_name is marked as flambda only)
There was a problem hiding this comment.
Not really, this is apparently what remained from removing closure, reintroducing it later while keeping the change on cmmgen interface, then going back on cmmgen interface...
edcd24e to
da55ae9
Compare
|
rebased |
This pull request contains the outstanding merge items for Flambda. We are continuing to split out a few more bits, but the end is nigh.
We are aware that some copyright headers need fixing in this diff.
There are also testsuite changes specific for Flambda which will come later. We need to arrange things so that certain tests are only run with Flambda or have different results with Flambda (or Closure).