Fix the no-naked-pointers GitHub run on release tags#10173
Fix the no-naked-pointers GitHub run on release tags#10173xavierleroy merged 1 commit intoocaml:trunkfrom
Conversation
Add --disable-dependency-generation, since the no-naked-pointers run is meant to run as quickly as possible. Ensure --enable-ocamltest is added, as in the other jobs, to allow the testsuite to run when building release tags and lower our release manager'se heart rate!
Octachron
left a comment
There was a problem hiding this comment.
I wholeheartedly approve the idea of not having tests that fails automatically on release commits.
So do I. But I'm increasingly doubtful that it's a good idea to have different configure defaults for "release" and "development" builds. That's a recipe for problems at release time. |
Ensure --enable-ocamltest is added, as in the other jobs, to allow the testsuite to run when building release tags. Add --disable-dependency-generation, since the no-naked-pointers run is meant to run as quickly as possible. (cherry picked from commit 4008866)
|
Cherry-picked to 4.12 as well. Regarding the problem, On a quiet 16 core Xeon Silver 4108, ocamltest takes 2 seconds to build with The testsuite already builds It's also possible with the various testing infrastructure to push the release commits (i.e. 53094bb and c6da7e0) but not the tag. opam-repository/bulk-builds/opam-health-check can all be set to run against the commit instead of the tag which would run all the tests in release mode. At that point the tag can be pushed (local CI then catches up, but is largely irrelevant). If a problem is found, |
Ensure --enable-ocamltest is added, as in the other jobs, to allow the testsuite to run when building release tags. Add --disable-dependency-generation, since the no-naked-pointers run is meant to run as quickly as possible. (cherry picked from commit 4008866)
Ensure --enable-ocamltest is added, as in the other jobs, to allow the testsuite to run when building release tags. Add --disable-dependency-generation, since the no-naked-pointers run is meant to run as quickly as possible. (cherry picked from commit 4008866)
Ensure --enable-ocamltest is added, as in the other jobs, to allow the testsuite to run when building release tags. Add --disable-dependency-generation, since the no-naked-pointers run is meant to run as quickly as possible. (cherry picked from commit 4008866)
Ensure --enable-ocamltest is added, as in the other jobs, to allow the testsuite to run when building release tags. Add --disable-dependency-generation, since the no-naked-pointers run is meant to run as quickly as possible. (cherry picked from commit 4008866)
The GitHub Actions runs for the 4.12 release tags have been failing, although unnoticed until it caused unnecessary stress for our release manager, @Octachron with today's!
The no-naked-pointers workflow predates the others - it's a very specific check which when multicore's merged will disappear. This PR reduces the time spent on that job with
--disable-dependency-generation(present in the other jobs apart from the full-flambda job, where dependency generation is meant to be tested) and, more importantly, adds--enable-ocamltestso the future release tags will pass CI.Running through CI just to make sure, and will then push to trunk and 4.12.