Add --disable-ocamltest to configure#9250
Merged
dra27 merged 2 commits intoocaml:trunkfrom Feb 14, 2020
Merged
Conversation
shindere
approved these changes
Feb 12, 2020
Contributor
|
Sorry for being very late on that one. Just approved.
@dra27 you may want to update the Changes entry.
David Allsopp (2020/01/16 08:59 -0800):
This PR adds `--disable-ocamltest` to go alongside
`--disable-ocamldoc` and `--disable-debugger`.
That's a very good idea, thanks.
Unfortunately, indeed. :)
It was my hope that ocamltest could become useful to other ocmal
projects, but I am indeed not sure this is going to happen soon.
which means it would be sensible for
opam to be using this switch,
yeah, and likewise for all distribution packaging.
but it also makes me wonder if we should
stop building `ocamltest` by default. `make -C testsuite all` *could*
check that `ocamltest` is built (in the same way as it checks that the
testsuite libraries are built). Alternatively, `ocamltest` could be
built by default for development builds (in the same way as `-Werror`
is activated).
@shindere, what do you think?
No strong opinion, I have to say. Especially given that it remains
possible for every developer to enable it in his/her personal
configuration.
Thanks again for the work!
Will be happy to press the merge button as soon as the Changes entry has
been completed, I think @nojb reviewed the code, too.
@dra27 would you mind leaivng a short note here? I am not always
notified when changes are pushed to a branch, I don't know what decides
whether I get notified or not.
|
--enable-ocamltest is paranoidly included in the CI scripts, although the trees are never pushed with a release VERSION at the tip.
724d3f0 to
fd6c0e3
Compare
Member
Author
|
Thanks, @shindere - I've updated |
Contributor
|
David Allsopp (2020/02/13 08:57 -0800):
Thanks, @shindere - I've updated `Changes` but pushed an additional
commit which changes the default.
Ah, I didn't necessarily expect that to happen in this PR, but why not,
after all.
|
Merged
3 tasks
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Jul 28, 2024
Add --disable-ocamltest to configure (cherry picked from commit 648d7a4)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Jul 28, 2024
Add --disable-ocamltest to configure (cherry picked from commit 648d7a4)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Jul 28, 2024
Add --disable-ocamltest to configure (cherry picked from commit 648d7a4)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Jul 28, 2024
Add --disable-ocamltest to configure (cherry picked from commit 648d7a4)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Jul 28, 2024
Add --disable-ocamltest to configure (cherry picked from commit 648d7a4)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Jul 28, 2024
Add --disable-ocamltest to configure (cherry picked from commit 648d7a4)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Aug 4, 2024
Add --disable-ocamltest to configure (cherry picked from commit 648d7a4)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Aug 4, 2024
Add --disable-ocamltest to configure (cherry picked from commit 648d7a4)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Aug 4, 2024
Add --disable-ocamltest to configure (cherry picked from commit 648d7a4)
dra27
added a commit
to dra27/ocaml
that referenced
this pull request
Aug 4, 2024
Add --disable-ocamltest to configure (cherry picked from commit 648d7a4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
--disable-ocamltestto go alongside--disable-ocamldocand--disable-debugger.We don't install
ocamltest, and I don't expect we're likely to in the near future, which means it would be sensible for opam to be using this switch, but it also makes me wonder if we should stop buildingocamltestby default.make -C testsuite allcould check thatocamltestis built (in the same way as it checks that the testsuite libraries are built). Alternatively,ocamltestcould be built by default for development builds (in the same way as-Werroris activated).@shindere, what do you think?