Clearer error in testsuite when ocamltest missing#9935
Merged
dra27 merged 1 commit intoocaml:trunkfrom Sep 23, 2020
Merged
Conversation
gasche
approved these changes
Sep 22, 2020
| ifeq "$(FLEXLINK_ENV)" "" | ||
| ocamltest := MKDLL="$(MKDLL)" SORT=$(SORT) MAKE=$(MAKE) $(ocamltest_program) | ||
| ifeq "$(ocamltest_program)" "" | ||
| ocamltest = $(error ocamltest not found in $(ocamltest_directory)) |
Member
There was a problem hiding this comment.
Out of curiosity: could you run this as a separate conditional first (without putting the rest in an extra else .. endif level), given that the build errors if it fires?
Member
Author
There was a problem hiding this comment.
I wanted to keep make working - i.e. the help target
Member
Author
|
Thank you! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #9250 in 4.11, it's possible to build OCaml without
ocamltest(this was added for various reasons). If you either build a release tag or explicitly configure with--disable-test, the message if you try to run the testsuite is a little off:This tiny PR (most of the diff is whitespace change) displays a slightly less awful error message: