Skip to content

fix: ignore [bigarray] correctly#8902

Merged
rgrinberg merged 1 commit intomainfrom
ps/rr/fix__ignore__bigarray__correctly
Oct 10, 2023
Merged

fix: ignore [bigarray] correctly#8902
rgrinberg merged 1 commit intomainfrom
ps/rr/fix__ignore__bigarray__correctly

Conversation

@rgrinberg
Copy link
Copy Markdown
Member

The way it was ignored previously, it would completely ignore locally
named libraries named bigarray.

Signed-off-by: Rudi Grinberg me@rgrinberg.com

@rgrinberg
Copy link
Copy Markdown
Member Author

Actually, the most correct approach would be to introduce an explicit stdlib for Lib.t and then just redirect bigarray to do that.

Anyway, for now this is good enough for a fix.

The way it was ignored previously, it would completely ignore locally
named libraries named bigarray.

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

<!-- ps-id: 781df074-c1dd-4beb-82bd-71b1f25d53ff -->
@rgrinberg rgrinberg force-pushed the ps/rr/fix__ignore__bigarray__correctly branch from 529576c to 07bccf8 Compare October 10, 2023 00:33
@rgrinberg rgrinberg requested a review from emillon October 10, 2023 00:33
@rgrinberg rgrinberg merged commit 9373447 into main Oct 10, 2023
@rgrinberg rgrinberg deleted the ps/rr/fix__ignore__bigarray__correctly branch October 10, 2023 12:58
@emillon emillon linked an issue Oct 10, 2023 that may be closed by this pull request
emillon added a commit to emillon/opam-repository that referenced this pull request Nov 28, 2023
CHANGES:

- Introduce `$ dune ocaml doc` to open and browse documentation. (ocaml/dune#7262, fixes
  ocaml/dune#6831, @EmileTrotignon)

- `dune cache trim` now accepts binary byte units: `KiB`, `MiB`, etc. (ocaml/dune#8618,
  @Alizter)

- No longer force colors for OCaml 4.03 and 4.04 (ocaml/dune#8778, @rgrinberg)

- Introduce new experimental odoc rules (ocaml/dune#8803, @jonjudlam)

- Introduce the `runtest_alias` field to the `cram` stanza. This allows
  removing default `runtest` alias from tests. (@rgrinberg, ocaml/dune#8887)

- Do not ignore libraries named `bigarray` when they are defined in conjunction
  with OCaml 5.0 (ocaml/dune#8902, fixes ocaml/dune#8901, @rgrinberg)

- Dependencies in the copying sandbox are now writeable (ocaml/dune#8920, @rgrinberg)

- Absent packages shouldn't prevent all rules from being loaded (ocaml/dune#8948, fixes
  ocaml/dune#8630, @rgrinberg)

- Correctly determine the stanza of menhir modules when `(include_subdirs
  qualified)` is enabled (@rgrinberg, ocaml/dune#8949, fixes ocaml/dune#7610)

- Display cache location in Dune log (ocaml/dune#8974, @nojb)

- Re-run actions whenever `(expand_aliases_in_sandbox)` changes (ocaml/dune#8990,
  @rgrinberg)

- Rules that only use internal dune actions (`write-file`, `echo`, etc.) can
  now be sandboxed. (ocaml/dune#9041, fixes ocaml/dune#8854, @rgrinberg)

- Do not re-run rules when their location changes (ocaml/dune#9052, @rgrinberg)

- Correctly ignore `bigarray` on recent version of OCaml (ocaml/dune#9076, @rgrinberg)

- Add `test_` prefix to default test name in `dune init project` (ocaml/dune#9257, fixes
  ocaml/dune#9131, @9sako6)

- Add `coqdoc_flags` field to `coq` field of `env` stanza allowing the setting
  of workspace-wide defaults for `coqdoc_flags`. (ocaml/dune#9280, fixes ocaml/dune#9139, @Alizter)

- [coq rules] Be more tolerant when coqc --print-version / --config don't work
  properly, and fallback to a reasonable default. This fixes problems when
  building Coq projects with `(stdlib no)` and likely other cases. (ocaml/dune#8966, fix
  ocaml/dune#8958, @Alizter, reported by Lasse Blaauwbroek)

- Dune will now run at a lower framerate of 15 fps rather than 60 when
  `INSIDE_EMACS`. (ocaml/dune#8812, @Alizter)

- dune-build-info: when `version=""` is found in a `META` file, we now return
  `None` as a version string (ocaml/dune#9177, @emillon)

- Dune can now be built and installed on Haiku (ocaml/dune#8795, fix ocaml/dune#8551, @Alizter)

- Mark installed directories in `dune-package` files. This fixes `(package)`
  dependencies against packages that contain such directories. (ocaml/dune#8953, fixes
  ocaml/dune#8915, @emillon)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Local libraries named bigarray are incorrectly removed

2 participants