Depend on any provided foreign_archives for ctypes stub generation#5475
Closed
mbacarella wants to merge 3 commits intoocaml:mainfrom
Closed
Depend on any provided foreign_archives for ctypes stub generation#5475mbacarella wants to merge 3 commits intoocaml:mainfrom
mbacarella wants to merge 3 commits intoocaml:mainfrom
Conversation
Signed-off-by: Michael Bacarella <m@bacarella.com>
rgrinberg
approved these changes
Feb 22, 2022
Member
rgrinberg
left a comment
There was a problem hiding this comment.
Thanks. Please add a CHANGES entry.
Signed-off-by: Michael Bacarella <m@bacarella.com>
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Mar 1, 2022
…e-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info and dune-action-plugin (3.0.3) CHANGES: - Do not enable warnings 63-70 by default (ocaml/dune#5476, fixes ocaml/dune#5464, @rgrinberg) - Allow %{read-lines} to introduce dynamic dependencies like %{read}. (ocaml/dune#5440, @anmonteiro) - Look up `gmake` before `make` (ocaml/dune#5474, fixes ocaml/dune#5470, @rgrinberg) - Handle empty output from `getconf` (ocaml/dune#5473 fixes ocaml/dune#5471, @mndrix) - Depend on any provided `foreign_archives` for ctypes stub generation (ocaml/dune#5475, @mbacarella)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sequences
ctypesstub generation to depend onforeign_archivesif they're provided in the enclosingexecutableorlibrarystanza.The use case this supports is a C library vendored in your project with complicated build rules that must run to completion before the rest of
ctypesevaluation can proceed, like a lengthy./configurescript that produces the vendored library's header files that must be included by the generated C stubs.This doesn't change the dune
ctypesextension language at all, and it should only fix functionality that was previously broken, so I don't believe it warrants bumping the ctypes extension version.