Closed
Conversation
rgrinberg
reviewed
Feb 22, 2022
If getconf prints nothing to its standard output, input_line raises End_of_file instead of returning a string. That should cause auto_concurrency to attempt the next approach for detecting concurrency. Fixes ocaml#5471 Signed-off-by: Michael Hendricks <michael@ndrix.org>
c670b19 to
c07aa31
Compare
Member
|
Thanks. I merged it. |
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Mar 1, 2022
…e-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info and dune-action-plugin (3.0.3) CHANGES: - Do not enable warnings 63-70 by default (ocaml/dune#5476, fixes ocaml/dune#5464, @rgrinberg) - Allow %{read-lines} to introduce dynamic dependencies like %{read}. (ocaml/dune#5440, @anmonteiro) - Look up `gmake` before `make` (ocaml/dune#5474, fixes ocaml/dune#5470, @rgrinberg) - Handle empty output from `getconf` (ocaml/dune#5473 fixes ocaml/dune#5471, @mndrix) - Depend on any provided `foreign_archives` for ctypes stub generation (ocaml/dune#5475, @mbacarella)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If getconf prints nothing to its standard output, input_line raises
End_of_file instead of returning a string. That, or any other problem
while capturing the CPU count, should cause auto_concurrency to
attempt the next approach for detecting concurrency.
Fixes #5471
Signed-off-by: Michael Hendricks michael@ndrix.org