Conversation
snowleopard
approved these changes
Feb 22, 2022
Collaborator
snowleopard
left a comment
There was a problem hiding this comment.
Looks good, thanks!
snowleopard
reviewed
Feb 22, 2022
| val which : path:Path.t list -> string -> Path.t option | ||
|
|
||
| (** "make" program *) | ||
| val make : path:Path.t list -> Path.t option |
Collaborator
There was a problem hiding this comment.
Was this just unused?
Member
Author
There was a problem hiding this comment.
Yes it was. If we had a warning that this code remain unused, we probably would have caught the bug in the PR that introduced it.
Collaborator
There was a problem hiding this comment.
Yeah, sad that we don't have it.
Signed-off-by: Rudi Grinberg <me@rgrinberg.com> ps-id: 9347ADDB-784C-4AC6-906E-870649C00D3E
31c3c03 to
a29c291
Compare
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Mar 1, 2022
…e-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info and dune-action-plugin (3.0.3) CHANGES: - Do not enable warnings 63-70 by default (ocaml/dune#5476, fixes ocaml/dune#5464, @rgrinberg) - Allow %{read-lines} to introduce dynamic dependencies like %{read}. (ocaml/dune#5440, @anmonteiro) - Look up `gmake` before `make` (ocaml/dune#5474, fixes ocaml/dune#5470, @rgrinberg) - Handle empty output from `getconf` (ocaml/dune#5473 fixes ocaml/dune#5471, @mndrix) - Depend on any provided `foreign_archives` for ctypes stub generation (ocaml/dune#5475, @mbacarella)
bobot
reviewed
Mar 10, 2022
| > EOF | ||
|
|
||
| $ PATH="$PWD/make:$PATH" dune build @make --force | ||
| make |
Collaborator
There was a problem hiding this comment.
@rgrinberg The test doesn't work if gmake is present in $PATH.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to look up gmake before make, but it seems that we accidentally dropped this behavior in 3.0