fix(include-qualified): delay invalid module errors #13146
Closed
anmonteiro wants to merge 1 commit intoocaml:mainfrom
Closed
fix(include-qualified): delay invalid module errors #13146anmonteiro wants to merge 1 commit intoocaml:mainfrom
anmonteiro wants to merge 1 commit intoocaml:mainfrom
Conversation
f158177 to
d61296c
Compare
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
d61296c to
af77de4
Compare
Collaborator
Author
|
replaced by a better alternative in #13156 |
anmonteiro
added a commit
that referenced
this pull request
Jan 2, 2026
better alternative to #13146 - introduce `Module_name.Unchecked.t`, which represents a source module that hasn't been included in any stanzas - `Module_name.Unchecked.t` becomes `Module_name.t` after calling `Module_name.Unchecked.validate_exn`, which is called when a module is included in a module group. closes #7628 refs #7605, which should be trivial to implement on top of this --------- Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on #13144
closes #7628
refs #7605, which should be trivial to implement on top of this