fix(include-qualified): delay module path evaluation#13156
fix(include-qualified): delay module path evaluation#13156anmonteiro merged 3 commits intoocaml:mainfrom
Conversation
30becb8 to
8429c25
Compare
| (** Represents a valid OCaml module name *) | ||
| type t | ||
|
|
||
| module Unchecked : sig |
There was a problem hiding this comment.
Could you add a brief summary of this module
|
Looking back at the original ticket issue, I'm not yet convinced that delaying the errors is the right approach. What if we allow users to just list the directories they want to be included? I.e. I think it would be a smaller change, and also a useful other in other contexts. |
8429c25 to
1e2cd8b
Compare
I disagree because of the case in #7628: $ tree
.
├── foo
│ └── bar.ml
├── invalid-module-name
│ └── opaque.txt
├── dune
├── dune-project
└── x.mlIMO there's no reason why the above should fail if you have an unrelated directory that won't contain OCaml sources. I think specifying directories renaming module interfaces is definitely useful, but I consider it to be an additional feature, not a replacement. |
4688aef to
b0f46ca
Compare
|
So if you were to modify #7628 so that |
b0f46ca to
d8dd664
Compare
|
To make that test-case more bullet proof, could you build something trivial defined with a |
|
Just pushed a commit doing that |
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
c606193 to
4372696
Compare
better alternative to #13146
Module_name.Unchecked.t, which represents a source module that hasn't been included in any stanzasModule_name.Unchecked.tbecomesModule_name.tafter callingModule_name.Unchecked.validate_exn, which is called when a module is included in a module group.closes #7628
refs #7605, which should be trivial to implement on top of this