refactor(module_trie): encode module paths as nonempty lists#13144
Merged
anmonteiro merged 1 commit intoocaml:mainfrom Dec 31, 2025
Merged
refactor(module_trie): encode module paths as nonempty lists#13144anmonteiro merged 1 commit intoocaml:mainfrom
anmonteiro merged 1 commit intoocaml:mainfrom
Conversation
Collaborator
anmonteiro
commented
Dec 31, 2025
- encodes in the type system that module paths may never be empty (at least they include the module name itslelf).
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Alizter
reviewed
Dec 31, 2025
| let compare = Nonempty_list.compare ~compare | ||
|
|
||
| let to_string Nonempty_list.(t :: ts) = | ||
| List.map ~f:to_string (t :: ts) |> String.concat ~sep:"." |
Collaborator
There was a problem hiding this comment.
Worth introducing Non_empty.to_list_map ~f? This pattern appears here and encode and the two kinds of :: makes it mysterious to read. This is perhaps more readable.
Collaborator
Author
There was a problem hiding this comment.
absolutely, i found other places would benefit from this and will introduce in a follow-up PR.
rgrinberg
approved these changes
Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.