Hide invisible columns in syslistview32 lists#9873
Merged
Conversation
|
@LeonarddeR: You interchanged the text regarding the last two headlines in the PR description. |
Collaborator
Author
|
Thanks for pointing this out. |
Member
|
Looks like checks are failing on this pr. I'll hold off on review until that is addressed. |
Collaborator
Author
|
Should now be fixed! |
michaelDCurran
approved these changes
Sep 17, 2019
Contributor
|
Hi!
Is this planned to be backported to 2019.2?
From: Michael Curran <notifications@github.com>
Sent: Tuesday, September 17, 2019 9:07 AM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: Re: [nvaccess/nvda] Hide invisible columns in syslistview32 lists (#9873)
@michaelDCurran approved this pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#9873?email_source=notifications&email_token=ACVCDEYX2TYTFXBLBHKQQGLQKB623A5CNFSM4H6K5VM2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCE5KPBA#pullrequestreview-289056644> , or mute the thread <https://github.com/notifications/unsubscribe-auth/ACVCDE7VBY6TJ4BCR3BLWMTQKB623ANCNFSM4H6K5VMQ> . <https://github.com/notifications/beacon/ACVCDE5NANWZONPPJYRK7Z3QKB623A5CNFSM4H6K5VM2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCE5KPBA.gif>
|
Member
|
No.
|
5 tasks
feerrenrut
pushed a commit
that referenced
this pull request
Feb 16, 2022
…ired (PR #13271) Fixes #8175 Follow up of #11745 Fixes regression from #11469, #9873 Summary: Getting list item content on 64 bit systems sometimes failed. Description of change: Based on #11745, fetching text content in-process fixed some but not all issues. The change adds: - Location fetching - Column header text fetching - Column order array fetching In short, everything that required allocating memory within a process using VirtualAlloc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #8268
Summary of the issue:
Some syslistview32 controls, for example in Becky internet mail or Dualtask DPS have columns that are invisible to the user, i.e. their width is less than or equal to 0. Yet in NVDA, they are shown if they have content.
Description of how this pull request fixes the issue:
When creating the name of a syslistview32 list item, don't add text for invisible columns.
Testing performed:
Tested in Becky internet mail and Dualtask DPS that hidden columns are no longer read.
Known issues with pull request:
None
Change log entry: