Fix getting name for SysListview32 item when column has no location#11469
Merged
Conversation
michaelDCurran
approved these changes
Aug 10, 2020
5 tasks
feerrenrut
pushed a commit
that referenced
this pull request
Feb 16, 2022
…ired (PR #13271) Fixes #8175 Follow up of #11745 Fixes regression from #11469, #9873 Summary: Getting list item content on 64 bit systems sometimes failed. Description of change: Based on #11745, fetching text content in-process fixed some but not all issues. The change adds: - Location fetching - Column header text fetching - Column order array fetching In short, everything that required allocating memory within a process using VirtualAlloc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #11468
Summary of the issue:
A listview in Internet Information Services (IIS) Manager is read incorrectly. This is because NVDA is unable to get the location of one of the columns, and the logic in NVDA expects a RectLTWH object to get the width from.
Description of how this pull request fixes the issue:
First check whether there's a location object to work with before getting its width.
Testing performed:
Tested that the list in IIS reads correctly again.
Known issues with pull request:
The IIS list really contains two columns, feature and description. NVDA is unable to get the text and location of the description column. I have no idea why this happens, it works ok when enforcing UIA. I assume it's a bug in IIS manager and there's not much we can do about it.
Change log entry: