Fix access to content of 64-bit syslistview32 controls#11745
Merged
Conversation
LeonarddeR
commented
Oct 10, 2020
| lvItem.iItem = item; | ||
| lvItem.iSubItem = subItem; | ||
| lvItem.cchTextMax = 512; | ||
| wchar_t textBuf[512]; |
Collaborator
Author
There was a problem hiding this comment.
I wonder whether this will be cleaned up correctly after use. Is there a better approach?
Member
There was a problem hiding this comment.
That buffer is just an array on the stack. That memory will go away once the function returns.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
michaelDCurran
previously approved these changes
Oct 12, 2020
Contributor
|
@michaelDCurran @feerrenrut Did you intend to merge this? |
5 tasks
feerrenrut
pushed a commit
that referenced
this pull request
Feb 16, 2022
…ired (PR #13271) Fixes #8175 Follow up of #11745 Fixes regression from #11469, #9873 Summary: Getting list item content on 64 bit systems sometimes failed. Description of change: Based on #11745, fetching text content in-process fixed some but not all issues. The change adds: - Location fetching - Column header text fetching - Column order array fetching In short, everything that required allocating memory within a process using VirtualAlloc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Supersedes #8190
Fixes #8175
Summary of the issue:
For some list view controls in 64-bit programs, most notably TortoiseSVN, NVDA is unable to output the list items.
Description of how this pull request fixes the issue:
Adds an in process implementation to fetch column contents.
Testing performed:
Tested that output works in 64-bit TortoiseSVN list views when commuting changes.
Known issues with pull request:
See in line code comment.
Change log entry: