Conversation
Fixes #20105 Summary of the issue: markdownTranslate.py previously removed inline markdownlint comments during preprocessing, so those comments were not preserved in generated XLIFF skeleton content. This could break round-tripping and comment fidelity for markdown files that embed inline lint directives. Description of user facing changes: No direct end-user NVDA feature change. This affects markdown/XLIFF tooling behavior used in docs workflows: inline markdownlint comments are now retained in skeleton output. Description of developer facing changes: Removed preprocessMarkdownLines usage across markdown/XLIFF processing paths. Updated inline markdownlint regex handling to capture and preserve inline markdownlint comments in skeletonizeLine. Added getSkeletonContentFromXliffText to avoid over-aggressive .strip() on skeleton text. Added a new fixture file: markdownlint_inlineComments.md Added unit coverage: test_generateXliff_preservesInlineMarkdownLintCommentsInSkeleton Uses module loading + patching of getRawGithubURLForPath to support file URI in test context. Description of development approach: This PR was heavily assisted through CoPilot. The change removes line preprocessing that was stripping semantic inline comments and instead handles markdownlint comments at skeletonization time so comments remain in output. Skeleton text extraction was adjusted to preserve meaningful whitespace/newline boundaries. Test strategy was expanded with a dedicated fixture and targeted assertion of skeleton content.
This pull request updates translations to languages being tracked from Crowdin. Co-authored-by: GitHub Actions <github-actions@github.com>
fixes #20200 fixes #20195 Summary of the issue: The option to keep mouse centered on the screen was originally my idea but is bringing more nuisance, and not much use. As talked with @CyrilleB79, the best solution would be to remove it and replace this idea with the gesture that he worked on #20238 Description of user facing changes: won't be able to keep mouse centered on the screen anymore Description of developer facing changes: Keep mouse centered options/functions/variables/tests have been removed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR synchronizes changes from a beta branch into master, combining documentation/translation updates with behavior and test adjustments for the markdown translation pipeline and NVDA Magnifier configuration.
Changes:
- Update
markdownTranslateskeleton handling to preserve inlinemarkdownlintdirectives and avoid stripping significant whitespace from extracted skeletons. - Remove the “Keep mouse centered” magnifier setting and associated UI/documentation/tests/config entries.
- Refresh Finnish locale documentation/gestures/symbol names and update Urdu translation catalog metadata/references.
Reviewed changes
Copilot reviewed 14 out of 104 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| user_docs/fi/userGuide.xliff | Finnish User Guide translation wording updates (Add-on Store, update mirror, sound split, etc.). |
| user_docs/en/userGuide.md | Removes the “Keep mouse centered” Magnifier User Guide section/anchor. |
| tests/unit/test_markdownTranslate.py | Adds a unit test ensuring inline markdownlint comments are preserved in the XLIFF skeleton; updates header. |
| tests/unit/test_magnifier/test_magnifier.py | Adjusts panning tests and removes keep-mouse-centered coverage aligned with feature removal. |
| tests/unit/test_magnifier/test_fullscreenMagnifier.py | Removes keep-mouse-centered tests and an unused import. |
| tests/markdownTranslate/markdownlint_inlineComments.md | Adds a fixture markdown file containing inline and full-line markdownlint directives. |
| source/markdownTranslate.py | Implements skeleton extraction preserving wrapper newlines only; preserves inline markdownlint directives in skeleton placeholders; updates skeleton update logic. |
| source/locale/ur/LC_MESSAGES/nvda.po | Updates PO header timestamps and many source references due to upstream line shifts. |
| source/locale/fi/symbols.dic | Updates Finnish symbol pronunciation entries (NBSP, caret, broken bar). |
| source/locale/fi/gestures.ini | Updates/expands Finnish gesture mappings (incl. zoom-in workaround and Office app key mappings). |
| source/gui/settingsDialogs.py | Removes Magnifier UI checkbox/help binding/config handling for keep-mouse-centered. |
| source/config/configSpec.py | Removes magnifier.keepMouseCentered config spec entry. |
| source/_magnifier/magnifier.py | Removes runtime keep-mouse-centered behavior and related imports/config usage. |
| source/_magnifier/fullscreenMagnifier.py | Removes fullscreen-specific keep-mouse-centered override and related helpers/imports. |
| source/_magnifier/config.py | Removes shouldKeepMouseCentered() accessor. |
| <segment state="final"> | ||
| <source>The list will display the currently installed version and the available version.</source> | ||
| <target>Luettelossa näytetään tällä hetkellä asennettuna oleva ja saatavilla oleva versio.</target> | ||
| <target>Luettelossa näkyvät tällä hetkellä asennettuna oleva ja saatavilla oleva versio.</target> |
Comment on lines
15287
to
15290
| #. Translators: The label for a checkbox to keep the mouse pointer centered in the magnifier view | ||
| #: gui\settingsDialogs.py:6176 | ||
| #: gui\settingsDialogs.py:6224 | ||
| msgid "Keep mouse pointer ¢ered in magnifier view" | ||
| msgstr "" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.