Add mouse to view magnifier command#20238
Merged
Merged
Conversation
Contributor
Author
|
Note: PR against beta since:
If you prefer me to open this PR against master, let me know and I will rebase. Thanks. |
seanbudd
approved these changes
May 29, 2026
seanbudd
left a comment
Member
There was a problem hiding this comment.
Thanks @CyrilleB79 - I've retargeted to master.
Can you please add a change log entry for 2026.3?
Contributor
Author
|
@seanbudd the PR is ready again. I have:
|
seanbudd
approved these changes
Jun 1, 2026
5 tasks
seanbudd
pushed a commit
that referenced
this pull request
Jun 3, 2026
fixes #20200 fixes #20195 Summary of the issue: The option to keep mouse centered on the screen was originally my idea but is bringing more nuisance, and not much use. As talked with @CyrilleB79, the best solution would be to remove it and replace this idea with the gesture that he worked on #20238 Description of user facing changes: won't be able to keep mouse centered on the screen anymore Description of developer facing changes: Keep mouse centered options/functions/variables/tests have been removed
Member
|
@CyrilleB79 - could you please resolve merge conflicts? |
Contributor
Author
|
@seanbudd I have fixed conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #20127
Summary of the issue:
A command (script) to move the mouse cursor in the center of the magnified view was requested.
Description of user facing changes:
An unassigned command (script) to move the mouse cursor in the center of the magnified view has been added.
For now, the command remains unassigned, taking into account that many NVDA users won't use Magnifier at all and that too many magnifier key assignments for Magnifier may create many unused default gestures for them.
The command can operate even if a mouse button is active so that this command can be used for dragging actions.
Description of developer facing changes:
N/A
Description of development approach:
Factorise common code with the
_keepMouseCenteredmethod, and keep the specific part related to mouse button locking support separated.Testing strategy:
Known issues with pull request:
None
Code Review Checklist: