Remove keep mouse centered#20268
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Removes the “Keep mouse centered” magnifier option across configuration, GUI, documentation, and tests.
Changes:
- Removed the
keepMouseCenteredconfig key and its accessor. - Removed the settings UI checkbox and related persistence/discard logic.
- Deleted user guide documentation and unit/end-to-end tests for the removed behavior.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| user_docs/en/userGuide.md | Removes documentation for the deleted “Keep mouse centered” option. |
| tests/unit/test_magnifier/test_magnifier.py | Removes the unit test for _keepMouseCentered; simplifies pan tests accordingly. |
| tests/unit/test_magnifier/test_fullscreenMagnifier.py | Removes fullscreen magnifier tests specifically validating _keepMouseCentered. |
| source/gui/settingsDialogs.py | Removes the UI checkbox and config persistence for keepMouseCentered. |
| source/config/configSpec.py | Deletes the keepMouseCentered config spec entry. |
| source/_magnifier/magnifier.py | Removes config-driven cursor-centering behavior and the base _keepMouseCentered method. |
| source/_magnifier/fullscreenMagnifier.py | Removes the fullscreen override of _keepMouseCentered. |
| source/_magnifier/config.py | Removes shouldKeepMouseCentered() accessor. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
fixes #20200
fixes #20195
Summary of the issue:
The option to keep mouse centered on the screen was originally my idea but is bringing more nuisance, and not much use.
As talked with @CyrilleB79, the best solution would be to remove it and replace this idea with the gesture that he worked on #20238
Description of user facing changes:
won't be able to keep mouse centered on the screen anymore
Description of developer facing changes:
Keep mouse centered options/functions/variables/tests have been removed
Description of development approach:
deleting everything
Testing strategy:
unit
Known issues with pull request:
Code Review Checklist: