Check if all tests pass as a single job#18554
Merged
SaschaCowley merged 4 commits intobetafrom Jul 27, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a centralized job for checking if all tests pass to simplify GitHub ruleset management. Instead of requiring each ruleset to specify every individual test job, they can now reference a single allTestsPass job that depends on all the required test and build jobs.
- Adds a new
allTestsPassjob that depends on all critical test and build jobs - Updates downstream jobs to depend on
allTestsPassinstead of listing individual dependencies - Simplifies ruleset configuration by providing a single status check point
seanbudd
commented
Jul 25, 2025
39 tasks
SaschaCowley
approved these changes
Jul 27, 2025
Member
Author
|
This PR is not working correctly |
seanbudd
added a commit
that referenced
this pull request
Jul 29, 2025
<!-- Please read and fill in the following template, for an explanation of the sections see: https://github.com/nvaccess/nvda/blob/master/projectDocs/dev/githubPullRequestTemplateExplanationAndExamples.md Please also note that the NVDA project has a Citizen and Contributor Code of Conduct which can be found at https://github.com/nvaccess/nvda/blob/master/CODE_OF_CONDUCT.md. NV Access expects that all contributors and other community members read and abide by the rules set out in this document while participating or contributing to this project. This includes creating or commenting on issues and pull requests. Please initially open PRs as a draft. When you would like a review, mark the PR as "ready for review". See https://github.com/nvaccess/nvda/blob/master/.github/CONTRIBUTING.md. --> ### Link to issue number: Fixup #18554
This was referenced Jul 29, 2025
seanbudd
added a commit
that referenced
this pull request
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Part of #17878
Summary of the issue:
GitHub Rulesets require specifying every job you wish to block a PR/push.
With many rulesets, adding new blocking jobs is fragile.
For example, if a new system test suite is added, it will need to be added to every ruleset.
Description of user facing changes:
none
Description of developer facing changes:
Blocking tests are added to the job
allTestsPass.Description of development approach:
We can use that job to confirm if a build can be merged or not via rulesets.
Testing strategy:
actions
Known issues with pull request:
none
Code Review Checklist:
@coderabbitai summary