Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a missing dependency in the GitHub Actions workflow by adding the typeCheck job to the list of required jobs that must pass before the "all tests pass" job can run. This ensures that type checking is properly included in the overall test validation process.
- Adds
typeCheckto theneedsdependency list for the "all tests pass" job
SaschaCowley
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixup of #18554
Summary of the issue:
#18345 was missed from #18554 as pyright checks were not on beta, and #18554 was targeted to beta