Skip to content

Move Crowdin upload out of allTestsPass#18576

Merged
seanbudd merged 1 commit intobetafrom
moveCrowdinUpload
Jul 29, 2025
Merged

Move Crowdin upload out of allTestsPass#18576
seanbudd merged 1 commit intobetafrom
moveCrowdinUpload

Conversation

@seanbudd
Copy link
Copy Markdown
Member

Link to issue number:

Fixup #18554

@seanbudd seanbudd marked this pull request as ready for review July 29, 2025 04:17
Copilot AI review requested due to automatic review settings July 29, 2025 04:17
@seanbudd seanbudd requested a review from a team as a code owner July 29, 2025 04:17
@seanbudd seanbudd requested a review from SaschaCowley July 29, 2025 04:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restructures the GitHub workflow dependency chain by moving the crowdinUpload job out of the allTestsPass dependency list and making it a direct dependency for downstream jobs that require it.

  • Removes crowdinUpload from allTestsPass dependencies to decouple translation uploads from test validation
  • Adds crowdinUpload as a direct dependency to cleanupCache and uploadSnapshot jobs

@seanbudd seanbudd merged commit f0b8a7c into beta Jul 29, 2025
4 of 6 checks passed
@seanbudd seanbudd deleted the moveCrowdinUpload branch July 29, 2025 04:18
@github-actions github-actions bot added this to the 2025.3 milestone Jul 29, 2025
@seanbudd seanbudd modified the milestones: 2025.3, 2025.2 Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants