Skip to content

Fix for dismiss braille message issue of remove redundant braille.BrailleHandler.update executions#16501

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
burmancomp:fixBrailleRedundantUpdates
May 8, 2024
Merged

Fix for dismiss braille message issue of remove redundant braille.BrailleHandler.update executions#16501
seanbudd merged 1 commit into
nvaccess:masterfrom
burmancomp:fixBrailleRedundantUpdates

Conversation

@burmancomp

@burmancomp burmancomp commented May 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Link to issue number:

fixes #16463

Summary of the issue:

Fix for issue of #16463
where braille message was not dismissed.

Description of user facing changes

Braille message should be dismissed when moving cursor.

Description of development approach

if buffer is message buffer BrailleHandler._dismissMessage is executed before BrailleHandler.scrollToCursorOrSelection.

Testing strategy:

message dismissed

Known issues with pull request:

none at this moment

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@burmancomp burmancomp marked this pull request as ready for review May 7, 2024 15:45
@burmancomp burmancomp requested a review from a team as a code owner May 7, 2024 15:45
@burmancomp burmancomp requested a review from seanbudd May 7, 2024 15:45
@seanbudd seanbudd merged commit c30ef08 into nvaccess:master May 8, 2024
@nvaccessAuto nvaccessAuto added this to the 2024.3 milestone May 8, 2024
@seanbudd seanbudd mentioned this pull request May 8, 2024
Closed
@burmancomp burmancomp deleted the fixBrailleRedundantUpdates branch May 8, 2024 06:29
@burmancomp burmancomp mentioned this pull request May 8, 2024
Closed
5 tasks
@seanbudd seanbudd mentioned this pull request May 10, 2024
Closed
burmancomp added a commit to burmancomp/nvda that referenced this pull request May 10, 2024
@burmancomp
Revert "Fix for dismiss braille message issue of remove redundant bra…
1397605 
…ille.BrailleHandler.update executions nvaccess#16501"
@burmancomp burmancomp mentioned this pull request May 10, 2024
Merged
seanbudd pushed a commit that referenced this pull request May 10, 2024
@burmancomp
revert 16463 and 16501 (#16519)
2d86502 
Reverts #16463 and #16501

Issues fixed
Issues reopened
Reopens #16456

Reason for revert
complexity

Can this PR be reimplemented? If so, what is required for the next attempt
at least execution of scrollToCursorOrSelection in _doNewObject
@burmancomp burmancomp mentioned this pull request May 14, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd seanbudd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2024.3

Development

Successfully merging this pull request may close these issues.

3 participants

@burmancomp @seanbudd @nvaccessAuto