-
-
Notifications
You must be signed in to change notification settings - Fork 784
Redundant braille.BrailleHandler.update executions #16456
Copy link
Copy link
Labels
component/braillep4https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityhttps://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityperformancetriagedHas been triaged, issue is waiting for implementation.Has been triaged, issue is waiting for implementation.
Metadata
Metadata
Assignees
Labels
component/braillep4https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityhttps://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityperformancetriagedHas been triaged, issue is waiting for implementation.Has been triaged, issue is waiting for implementation.
Type
Fields
Give feedbackNo fields configured for issues without a type.
About
There are following code lines in
braille.BrailleHandler._handlePendingUpdate:if scrollTo is not None: self.scrollToCursorOrSelection(scrollTo) if self.buffer is self.mainBuffer: self.update()scrollToCursorOrSelectionshould executescrollTowhen region is type of TextInfoRegion.scrollToin turn executesupdateDisplaywhich executesbraille.BrailleHandler.update.Because region is type of TextInfoRegion and thus buffer should be mainBuffer,
braille.BrailleHandler.updateis executed twice.There is similar case in
braille.BrailleHandler._doNewObjectfunction:self.scrollToCursorOrSelection(region) if self.buffer is self.mainBuffer: self.update()What is the harm? At least log file, when using debug level, contain redundant ""Braille window dots" lines.
Steps to reproduce:
Log level to debug and investigation of log when there is braille display in use (I have not looked at log when braille display is no display).
Actual behavior:
redundant log lines
Expected behavior:
no redundant log lines
NVDA logs, crash dumps and other attachments:
System configuration
NVDA installed/portable/running from source:
running from source
NVDA version:
current main branch code
Windows version:
windows 10 22h2
Name and version of other software in use when reproducing the issue:
Other information about your system:
Other questions
Does the issue still occur after restarting your computer?
yes
Have you tried any other versions of NVDA? If so, please report their behaviors.
If NVDA add-ons are disabled, is your problem still occurring?
Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?