Skip to content

revert 16463 and 16501#16519

Merged
seanbudd merged 2 commits into
nvaccess:masterfrom
burmancomp:revert_16463_and_16501
May 10, 2024
Merged

revert 16463 and 16501#16519
seanbudd merged 2 commits into
nvaccess:masterfrom
burmancomp:revert_16463_and_16501

Conversation

@burmancomp

@burmancomp burmancomp commented May 10, 2024

Copy link
Copy Markdown
Contributor

Reverts PR

Reverts #16463 and #16501

Issues fixed

Issues reopened

Reopens #16456

Reason for revert

complexity

Can this PR be reimplemented? If so, what is required for the next attempt

at least execution of scrollToCursorOrSelection in _doNewObject

@burmancomp burmancomp requested a review from a team as a code owner May 10, 2024 02:50
@burmancomp burmancomp requested a review from seanbudd May 10, 2024 02:50
@seanbudd

Copy link
Copy Markdown
Member

Thanks @burmancomp

@seanbudd seanbudd merged commit 2d86502 into nvaccess:master May 10, 2024
@nvaccessAuto nvaccessAuto added this to the 2024.3 milestone May 10, 2024
@burmancomp burmancomp deleted the revert_16463_and_16501 branch May 10, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants