Skip to content

Beta to master#15926

Merged
seanbudd merged 5 commits into
masterfrom
beta
Dec 14, 2023
Merged

Beta to master#15926
seanbudd merged 5 commits into
masterfrom
beta

Conversation

@seanbudd

Copy link
Copy Markdown
Member

No description provided.

Fixes #15919

Summary of the issue:
Add-ons which are already disabled have a disabled action available in the add-on store updatable tab.
A similar problem exists for add-ons pending removal.

Description of user facing changes
You can no longer disable or remove add-ons from the updatable add-ons tab.
This is consistent with the enable action (currently disabled from the updatable tab).

Description of development approach
Add filtering to remove updating actions from available statuses for disabling and removing add-ons.
Update documentations and release blurb for 2024.1
Fixes #15719

Summary of the issue:
If an add-ons install failed, it might never be cleaned up, causing NVDA to be constantly expecting there are add-ons pending install.
This causes a warning dialog that NVDA must be restarted when closing the add-on store.

Description of user facing changes
Pending installs that fail are removed and cleaned up, ensuring it is easy to attempt a future install.
The warning dialog no longer fires as NVDA cleans up failed installs.

Description of development approach
Clear the pending install set and delete pending install add-on folders after loading add-ons.
When loading add-ons, all installs should complete, and there should be no new pending installs from the user.

If an install fails, also attempt to clean up the files immediately after.
@seanbudd seanbudd requested review from a team as code owners December 14, 2023 22:57
@seanbudd seanbudd merged commit 0db9552 into master Dec 14, 2023
@seanbudd seanbudd added this to the 2024.2 milestone Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant