Conversation
michaelDCurran
approved these changes
Dec 14, 2023
Adriani90
pushed a commit
to Adriani90/nvda
that referenced
this pull request
Mar 13, 2024
Fixes nvaccess#15919 Summary of the issue: Add-ons which are already disabled have a disabled action available in the add-on store updatable tab. A similar problem exists for add-ons pending removal. Description of user facing changes You can no longer disable or remove add-ons from the updatable add-ons tab. This is consistent with the enable action (currently disabled from the updatable tab). Description of development approach Add filtering to remove updating actions from available statuses for disabling and removing add-ons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #15919
Summary of the issue:
Add-ons which are already disabled have a disabled action available in the add-on store updatable tab.
A similar problem exists for add-ons pending removal.
Description of user facing changes
You can no longer disable or remove add-ons from the updatable add-ons tab.
This is consistent with the enable action (currently disabled from the updatable tab).
Description of development approach
Add filtering to remove updating actions from available statuses for disabling and removing add-ons.
Testing strategy:
Manual testing using STR in #15919
Also tested by removing an add-on, and attempting to re-remove it from the updatable add-ons tab.
Known issues with pull request:
None
Code Review Checklist: