Final master to beta for 2024.1#15914
Merged
Merged
Conversation
) I have put various little changes in the same PR. Let me know if I should divide it. Link to issue number: Follow-up of #15867. Summary of the issue: Various issues seen in #15867 or while investigating on it (e.g. looking at usages of gesture.send()): Script BrowseModeTreeInterceptor.script_passThrough in browseMode.py has a description. It should not since: 1. It is only dedicated to specific key which should not be remapped; 2. There should not be any input help associated to it, since this "pass through" should be transparent to users. In Eclipse, when no selected auto-completion item can be found, NVDA+D should not pass the gesture through. Indeed gesture.send() should not be used since NVDA+D is not a native gesture of this IDE. An error message should be reported instead. The PowerPoint script does not show up in its category, whereas it was the goal in Adding command gesture categories for appmodules #15867. With 15867, scripts to set headers of rows or columns in Excel or Word have their description shortened and the details of its usage (e.g. 1 press, 2 presses) is not reported anymore in input help. This is not consistent with other scripts. It's better to keep more details in input help as for other scripts.
Relates to #14974 Summary of the issue: Add-on authors wish to have a stable API so that they can change the base URL of the add-on store. This allows add-ons to use a mirror for the add-on store. Description of user facing changes None Description of development approach Change BASE_URL for the add-on store to be public
Relates to #15719 Summary of the issue: When triaging #15719, important information from the log is missing. The reporter is stuck with a pending restart dialog appearing every time they close the add-on store. For reasons other than a pending install, the first add-on found to be modified is logged. For pending installs, all add-ons pending an install should be logged. Description of user facing changes None Description of development approach Log all add-ons pending install when triggering the restart dialog
Summary of the issue: NVDA allows the user to select text in browse mode. In web browsers where NVDA uses a virtualBuffer to make the content accessible, the selected text is only a plain text representation, and thus copying this text to another application such as MS Word looses all rich formatting. It is also impossible for the user to perform a web page specific action on the selected text, as the web page / application is unaware of NVDA's selection. E.g. Hypothesis's annotation and highlighting features. Description of user facing changes A new Native Selection mode (toggled by NVDA+shift+f10) is now available in NVDA's browse mode for Mozilla Firefox. When turned on, selecting text in browse mode will also manipulate Firefox's own native selection. And copying text with control+c will pass straight through to Firefox, thus copying the rich content, rather than NvDA's plain text representation. Description of development approach Added an updateAppSelection method to the Gecko virtualBuffer Python class, which updates the native selection to mirror NVDA's current browse mode selection, by using the new IAccessibleTextSelectionContainer interface in IAccessible2. This change also required the following: The gecko virtualBuffer backend exposes needed attributes such as IAccessible2 uniqueID on all text runs, so it can be later used to update the native selection via IAccessibleTextSelectionContainer. The base virtualBuffer storage generated XML also includes offsetFromStartOfNode and offsetFromEndOfNode on text tags, so that it is clear how far in the range starts from the real start and end of the text node. XMLTextParser in NvDA now maintains a controlField stack and controlEnd fields now include a reference to the same attribs dictionary that was used on the controlStart. This is so we have all the information about a field by only looking at its controlEnd. Such as when traversing through fields backwards. The Gecko virtualBuffer textInfo's updateSelection method calls updateAppSelection if native selection mode is toggled on.
Link to issue number: Closes #11465 Summary of the issue: NVDAObjects\IAccessible\winword.py contains a script that is not documented (no input help, not mentioned in user Guide). It has been introduced in commit 465dce8 when #3110 has been implemented as a demo script to test the new headers reading capability. This script cause an error in the log when called outside of a table. Description of user facing changes No more error when pressing NVDA+shift+H in Word document. Description of development approach Just removed the script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final merge for 2024.1 release, using commit
966fffb52cb9a03f8354a89bf4a2ec6987cfb3a5from master.Changes intended for 2024.1 must now set base/target to the beta branch
Merge not squash