Make add-on store base end point part of the public API#15893
Conversation
|
@cary-rowen can you confirm that these changes are sufficient to create a stable API for your mirroring add-on? |
|
Isn't it possible to provide a default host that is also available from China? Why not use github pages, for example? |
|
@LeonarddeR - I would consider that out of scope and somewhat covered by #14974 |
|
Note that Add-on Updater allows user to select one of the supported mirrors from its GUI, which IMHO is a much nicer UX. While I don't think we should promote any particular mirrors in NVDA as such, offering ability to add an URL from the config dialog seems much better than just making API for add-ons more stable. |
|
Hi @seanbudd, |
|
Hi @cary-rowen, as mentioned earlier, that is out of scope of what we are trying to do here, the issue exists to track that further work. Now that the add-on API is considered stable we can ensure the API your add-on needs is stable. |
|
If only exposing the add-on store API is considered then this can be considered stable. |
Relates to nvaccess#14974 Summary of the issue: Add-on authors wish to have a stable API so that they can change the base URL of the add-on store. This allows add-ons to use a mirror for the add-on store. Description of user facing changes None Description of development approach Change BASE_URL for the add-on store to be public
Link to issue number:
Relates to #14974
Summary of the issue:
Add-on authors wish to have a stable API so that they can change the base URL of the add-on store.
This allows add-ons to use a mirror for the add-on store.
Description of user facing changes
None
Description of development approach
Change BASE_URL for the add-on store to be public
Testing strategy:
Confirm with add-on authors that changes are sufficient
Known issues with pull request:
None
Code Review Checklist: