Fix up of #15867 and other issues found during its investigation#15906
Merged
Conversation
See test results for failed build of commit 15e9a60067 |
seanbudd
reviewed
Dec 11, 2023
seanbudd
approved these changes
Dec 11, 2023
Adriani90
pushed a commit
to Adriani90/nvda
that referenced
this pull request
Mar 13, 2024
…ion (nvaccess#15906) I have put various little changes in the same PR. Let me know if I should divide it. Link to issue number: Follow-up of nvaccess#15867. Summary of the issue: Various issues seen in nvaccess#15867 or while investigating on it (e.g. looking at usages of gesture.send()): Script BrowseModeTreeInterceptor.script_passThrough in browseMode.py has a description. It should not since: 1. It is only dedicated to specific key which should not be remapped; 2. There should not be any input help associated to it, since this "pass through" should be transparent to users. In Eclipse, when no selected auto-completion item can be found, NVDA+D should not pass the gesture through. Indeed gesture.send() should not be used since NVDA+D is not a native gesture of this IDE. An error message should be reported instead. The PowerPoint script does not show up in its category, whereas it was the goal in Adding command gesture categories for appmodules nvaccess#15867. With 15867, scripts to set headers of rows or columns in Excel or Word have their description shortened and the details of its usage (e.g. 1 press, 2 presses) is not reported anymore in input help. This is not consistent with other scripts. It's better to keep more details in input help as for other scripts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have put various little changes in the same PR. Let me know if I should divide it.
Link to issue number:
Follow-up of #15867.
Summary of the issue:
Various issues seen in #15867 or while investigating on it (e.g. looking at usages of
gesture.send()):BrowseModeTreeInterceptor.script_passThroughinbrowseMode.pyhas a description. It should not since: 1. It is only dedicated to specific key which should not be remapped; 2. There should not be any input help associated to it, since this "pass through" should be transparent to users.NVDA+Dshould not pass the gesture through. Indeedgesture.send()should not be used since NVDA+D is not a native gesture of this IDE. An error message should be reported instead.Description of user facing changes
Fix all these points.
Description of development approach
See code.
Testing strategy:
Manual tests:
2. Checked that pass through script are not reported in input help, nor present in the input gesture dialog.
3. Check that PowerPoint's control+shift+S script is listed in the PowerPoint category of Input gesture dialog.
4. Check input help in Word and Excel for set column/row headers commands.
Not tested:
Known issues with pull request:
None
Code Review Checklist: