Conversation
See test results for failed build of commit 6d04ccf4e6 |
lukaszgo1
reviewed
Dec 8, 2023
Adriani90
pushed a commit
to Adriani90/nvda
that referenced
this pull request
Mar 13, 2024
…s#15892) Relates to nvaccess#15719 Summary of the issue: When triaging nvaccess#15719, important information from the log is missing. The reporter is stuck with a pending restart dialog appearing every time they close the add-on store. For reasons other than a pending install, the first add-on found to be modified is logged. For pending installs, all add-ons pending an install should be logged. Description of user facing changes None Description of development approach Log all add-ons pending install when triggering the restart dialog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Relates to #15719
Summary of the issue:
When triaging #15719, important information from the log is missing.
The reporter is stuck with a pending restart dialog appearing every time they close the add-on store.
For reasons other than a pending install, the first add-on found to be modified is logged.
For pending installs, all add-ons pending an install should be logged.
Description of user facing changes
None
Description of development approach
Log all add-ons pending install when triggering the restart dialog
Testing strategy:
Tested by installing an external add-on and an add-on from the store, ensure these both are logged.
Known issues with pull request:
None
Code Review Checklist: