Always use utf-8 for addon store caches#15241
Merged
Merged
Conversation
seanbudd
reviewed
Aug 1, 2023
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
Contributor
Author
|
After not removing the file, it appears that the exception is getting logged multiple times. After launching the add-on store, when switching tabs sometimes and, when focused on the add-on with the invalid cache. |
Member
|
@mzanm - I think that is preferred. Users should be able to fix this by reinstalling from the add-on store. Otherwise, it is helpful to keep the file around for debugging. We can perhaps supress the log level, however, I figure it would be helpful noise to have to get feedback from alpha/beta users as well as indicate to current beta users that they may need to reinstall their add-ons. |
seanbudd
approved these changes
Aug 2, 2023
This was referenced Aug 30, 2023
Closed
seanbudd
added a commit
that referenced
this pull request
Aug 30, 2023
…lid (#15346) Raised due to #15345 Fix up of #15241 Summary of the issue: Add-ons installed from the add-on store in NVDA versions before 2023.2beta2 may have invalid encoding in their add-on store cache file. This causes an error to be logged, and the add-on to be treated as an externally installed add-on. The file name of the invalid add-on cache file is not logged with the error. This information is required for debugging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #15231
Summary of the issue:
If NVDA language is set to Serbian, the cache could get corrupted while reading or writing do to the encoding not specified while opening the file.
Description of user facing changes
NVDA add-on store works with Serbian. Also, If the cached installed addon data is invalid, the exception will be logged similar to the add-on store cache, instead of preventing the add-on store from launching.
Description of development approach
Testing strategy:
Installed multiple add-ons, with Serbian translation and without, while NVDA's language is set to Serbian.
Known issues with pull request:
None.
Change log entries:
New features
Changes
Bug fixes
For Developers
Code Review Checklist: