Improve error logging when an add-on store cached add-on file is invalid#15346
Merged
Conversation
michaelDCurran
approved these changes
Aug 30, 2023
See test results for failed build of commit 56de140dbd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Raised due to #15345
Fix up of #15241
Summary of the issue:
Add-ons installed from the add-on store in NVDA versions before 2023.2beta2 may have invalid encoding in their add-on store cache file.
This causes an error to be logged, and the add-on to be treated as an externally installed add-on.
The file name of the invalid add-on cache file is not logged with the error.
This information is required for debugging.
Description of user facing changes
Improve logging
Code Review Checklist: