Skip to content

NVDA addons store becomes unusable if NVDA's language is set to Serbian #15231

@nidza07

Description

@nidza07

Steps to reproduce:

  1. Make sure NVDA's language is set to Serbian (possibly affects other languages as well).
  2. Open the addons store, and install any available addon. In this case, I chose NVDA remote.

Actual behavior:

In the middle of the installation, the following error is logged:

ERROR - unhandled exception (21:25:01.901) - MainThread (11864):
Traceback (most recent call last):
File "gui_addonStoreGui\controls\storeDialog.pyc", line 238, in onClose
File "gui_addonStoreGui\viewModels\store.pyc", line 333, in installPending
File "gui_addonStoreGui\viewModels\store.pyc", line 350, in _doInstall
File "_addonStore\dataManager.pyc", line 274, in cacheInstalledAddon
File "json_init
.pyc", line 180, in dump
File "encodings\cp1252.pyc", line 19, in encode
UnicodeEncodeError: 'charmap' codec can't encode character '\u010d' in position 50: character maps to

After this, the installation dialog is completely stuck. If I manually restart NVDA however, the addon seems to be installed completely fine. However, now, the addons store is completely broken. If I try to open it again, the following error is logged and the store does not open:

ERROR - unhandled exception (21:27:36.875) - MainThread (2120):
Traceback (most recent call last):
File "gui\blockAction.pyc", line 72, in funcWrapper
File "gui_init_.pyc", line 394, in onAddonStoreCommand
File "gui_addonStoreGui\viewModels\store.pyc", line 65, in init
File "baseObject.pyc", line 62, in get
File "baseObject.pyc", line 168, in _getPropertyViaCache
File "_addonStore\dataManager.pyc", line 305, in get_installedAddonGUICollection
File "addonHandler_init
.pyc", line 392, in _addonStoreData
File "addonStore\dataManager.pyc", line 281, in getCachedInstalledAddonData
File "json_init
.pyc", line 296, in load
File "json_init
.pyc", line 348, in loads
File "json\decoder.pyc", line 337, in decode
File "json\decoder.pyc", line 355, in raw_decode
json.decoder.JSONDecodeError: Expecting value: line 1 column 71 (char 70)

The store is now completely unusable, unless you manually delete the "remote.json" file that was generated in the addons folder.

Expected behavior:

The store should install the addon and work normally

NVDA logs, crash dumps and other attachments:

I've pasted the errors, but if a full log is necessary, I can attach it.

System configuration

NVDA installed/portable/running from source:

Portable, but happens with installed too

NVDA version:

alpha-28809,2c337e53 (2023.3.0.28809)

Windows version:

Windows 10 22H2

Name and version of other software in use when reproducing the issue:

None

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

I believe that this issue did not occur before the addons store started supporting translated addons into other languages.

If NVDA add-ons are disabled, is your problem still occurring?

Yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

NA

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature/addon-storeFeatures / behavior of the add-on Storep3https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#prioritytriagedHas been triaged, issue is waiting for implementation.

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions