Always speak labels of landmarks and regions when jumping inside from outside using quicknav or focus in browse mode#14303
Merged
Merged
Conversation
… jumping inside them from outside with focus or quicknav.
seanbudd
approved these changes
Oct 26, 2022
See test results for failed build of commit 2690e366a1 |
This was referenced Jan 11, 2023
michaelDCurran
pushed a commit
that referenced
this pull request
Jan 29, 2023
Fixes #14519 Fixup of #14303 Summary of the issue: #14303 fixed a bug where landmarks and regions were not correctly reported in some cases. However, #14303 failed to check/respect the config setting for reportLandmarks Description of user facing changes Landmarks are no longer reported incorrectly Description of development approach Check the config setting when reporting landmarks/regions in the case introduced by #14303
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #13307
Fixes #13996
Summary of the issue:
Some time after NVDA 2019.2, labels of landmarks and regions were no longer automatically spoken when jumping inside from outside using quick nav or focus in browse mode.
Although a label should not be spoken when moving into a landmark or region with the arrow keys if the label is from an associated node via aria-labelledby, when jumping in with quick nav / focus, it always should, as context is more important than rare duplication.
Description of user facing changes
A landmark or region's name is always automatically spoken when jumping inside from outside using quick navigation or focus in browse mode.
Description of development approach
landmark and region roles are treated the same as groupings and propertypages in getcontrolFieldSpeech. I.e. the name is always announced if it has one when entering from outside for a reason of quicknav or focus.
Testing strategy:
Performed steps in issue #13307
Created a system test based on testcase in #13307.
Known issues with pull request:
None known.
Change log entries:
New features
Changes
Bug fixes
For Developers
Code Review Checklist: