Fixup 14303: Respect config reportLandmarks#14530
Merged
Merged
Conversation
michaelDCurran
requested changes
Jan 12, 2023
See test results for failed build of commit f2486084a8 |
michaelDCurran
requested changes
Jan 13, 2023
michaelDCurran
left a comment
Member
There was a problem hiding this comment.
The logic needs to be broadened I think - see my two related code suggestions.
Co-authored-by: Michael Curran <mick@nvaccess.org>
michaelDCurran
approved these changes
Jan 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #14519
Fixup of #14303
Summary of the issue:
#14303 fixed a bug where landmarks and regions were not correctly reported in some cases.
However, #14303 failed to check/respect the config setting for
reportLandmarksDescription of user facing changes
Landmarks are no longer reported incorrectly
Description of development approach
Check the config setting when reporting landmarks/regions in the case introduced by #14303
Testing strategy:
Manually tested the STR outlined in #14519
Known issues with pull request:
None
Change log entries:
None, fixes unreleased bug
Code Review Checklist: