Skip to content

Fixup 14303: Respect config reportLandmarks#14530

Merged
michaelDCurran merged 3 commits into
masterfrom
fix-14519
Jan 29, 2023
Merged

Fixup 14303: Respect config reportLandmarks#14530
michaelDCurran merged 3 commits into
masterfrom
fix-14519

Conversation

@seanbudd

@seanbudd seanbudd commented Jan 11, 2023

Copy link
Copy Markdown
Member

Link to issue number:

Fixes #14519
Fixup of #14303

Summary of the issue:

#14303 fixed a bug where landmarks and regions were not correctly reported in some cases.
However, #14303 failed to check/respect the config setting for reportLandmarks

Description of user facing changes

Landmarks are no longer reported incorrectly

Description of development approach

Check the config setting when reporting landmarks/regions in the case introduced by #14303

Testing strategy:

Manually tested the STR outlined in #14519

  1. open preferences, Document formatting, and disable landmarks reporting;
  2. go i.e. to issues page;
  3. press 3 to find h3 Footer navigation.
  4. Check whether or not "landmark" is reported

Known issues with pull request:

None

Change log entries:

None, fixes unreleased bug

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd added this to the 2023.1 milestone Jan 11, 2023
@seanbudd seanbudd requested a review from a team as a code owner January 11, 2023 05:58
Comment thread source/speech/speech.py Outdated
@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit f2486084a8

@michaelDCurran michaelDCurran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic needs to be broadened I think - see my two related code suggestions.

Comment thread source/speech/speech.py Outdated
Comment thread source/speech/speech.py Outdated
Co-authored-by: Michael Curran <mick@nvaccess.org>
@michaelDCurran michaelDCurran merged commit 799c484 into master Jan 29, 2023
@michaelDCurran michaelDCurran deleted the fix-14519 branch January 29, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Landmarks read even if disabled from formatting preferences

3 participants