Merged
Conversation
seanbudd
reviewed
Nov 18, 2021
Comment on lines
+237
to
+242
| # As of py2exe 0.11.0.0 if the forcibly included package contains subpackages | ||
| # they need to be listed explicitly (py2exe issue 113). | ||
| "NVDAObjects.IAccessible", | ||
| "NVDAObjects.JAB", | ||
| "NVDAObjects.UIA", | ||
| "NVDAObjects.window", |
Member
There was a problem hiding this comment.
How did you determine these - and how can we be confident that nothing is missing?
Contributor
Author
There was a problem hiding this comment.
Unfortunately this has to be done manually.
We know that if the forcibly included package has no sub-packages it is included successfully and the only one known package with sub-packages we need to include that way is NVDAObjects. Since no sub-packages in NVDAObjects has sub-packages it is sufficient to list all of them. To ensure that this procedure works I've just compared count of files inside each sub-package in the library.zipwith amount of files in the repository.
Member
There was a problem hiding this comment.
Thanks for the explanation, LGTM
seanbudd
approved these changes
Nov 18, 2021
michaelDCurran
added a commit
that referenced
this pull request
Mar 18, 2022
Necessary as Pyt2exe 0.11.1.0 has produces an exception when trying to parse our rlease version strings. This reverts commit 0f74330.
This was referenced Mar 18, 2022
michaelDCurran
added a commit
that referenced
this pull request
Mar 20, 2022
Some time after we branched for the 2021.3 beta, pr #13066 was merged to master, which upgraded Py2exe to 0.11.0.1. However, this version of Py2exe fails to build the NVDA distribution when using optimized Python (E.g. when building a release). This was not noticed until trying to build the NVDA 2022.1beta1 tag. Description of how this pull request fixes the issue: This pr upgrades py2exe to 0.11.1.0.
seanbudd
pushed a commit
that referenced
this pull request
Jun 21, 2022
When checking the change log translation, I have found a wrong reference in an item of the change log. I have thus checked all the refs for 2022.2. Link to issue number: None Follow-up of various issues. Summary of the issue: Some of the GitHub references in the change log were targetting wrong issue or PR. Description of user facing changes The references have been fixed in the change log document. Description of development approach Fixed the following references: Fixup of PR 13082: fix a misspell in DefaultAppArgs and no longer use globalVars.appArgs in a boolean context (#13386) #13386 replaced by Windows 10/11 Calculator: allow NVDA to announce more operations by suppressing only a limited number of keyboard commands #13383 Revert "Update to py2exe 0.11.0.1 (#13066)" #13508 replaced by Windows 11 Design Elements Are Not Reported by NVDA When Mouse Tracking Is On #13506 Fixup of PR 13082: fix a misspell in DefaultAppArgs and no longer use globalVars.appArgs in a boolean context (#13386) #13386 (bis) replaced by Windows 11 Notepad: status bar is not announced #13688 Also, I have replaced #13276 (Libre Office issue) by #13277 (associated PR) since the issue description is not related at all with the change for developers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #12357
Summary of the issue:
NVDA currently uses py2exe version 0.10.1.0 to create a binary version since never versions of py2exe causes errors during build (py2exe/py2exe#112). These errors has been fixed by @albertosottile in version 0.11.0.0. While never version of py2exe does not provide us with any advantages for now not upgrading regularly might make it difficult to do so when we would need to move to Python 3.10 or later (currently used version of py2exe supports only up to 3.9).
Description of how this pull request fixes the issue:
Updates version of py2exe we're using to 0.11.0.1
Testing strategy:
NVDAObjectspackage is included in the library.zipKnown issues with pull request:
None known
Change log entries:
For Developers
Code Review Checklist: