Fixes in the change log for NVDA 2022.2#13817
Merged
seanbudd merged 2 commits intonvaccess:betafrom Jun 21, 2022
Merged
Conversation
See test results for failed build of commit 2b1235359c |
This comment was marked as off-topic.
This comment was marked as off-topic.
Contributor
Author
|
Also @seanbudd, @feerrenrut, please have a look at this PR before declaring translation freeze. Thanks. |
Member
This is likely a bug, and not related to the length of build times increasing. |
seanbudd
approved these changes
Jun 21, 2022
Member
I think this was missed, and needs to be added to the process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
When checking the change log translation, I have found a wrong reference in an item of the change log. I have thus checked all the refs for 2022.2.
Link to issue number:
None
Follow-up of various issues.
Summary of the issue:
Some of the GitHub references in the change log were targetting wrong issue or PR.
Description of user facing changes
The references have been fixed in the change log document.
Description of development approach
Fixed the following references:
Also, I have replaced #13276 (Libre Office issue) by #13277 (associated PR) since the issue description is not related at all with the change for developers.
Testing strategy:
Manual test: Check each change log item in the change log generated by appVeyor in this PR.
Known issues with pull request:
I have also found some PR refs even if there are associated issues. The rule is usually to reference the issue when there is one. But I have not bothered to fix it since it is easy to find the issue when you have the PR.
Additional note:
Change log entries:
None
Code Review Checklist: