Skip to content

Fixes in the change log for NVDA 2022.2#13817

Merged
seanbudd merged 2 commits intonvaccess:betafrom
CyrilleB79:changeLogRefs
Jun 21, 2022
Merged

Fixes in the change log for NVDA 2022.2#13817
seanbudd merged 2 commits intonvaccess:betafrom
CyrilleB79:changeLogRefs

Conversation

@CyrilleB79
Copy link
Copy Markdown
Contributor

@CyrilleB79 CyrilleB79 commented Jun 20, 2022

Context

When checking the change log translation, I have found a wrong reference in an item of the change log. I have thus checked all the refs for 2022.2.

Link to issue number:

None
Follow-up of various issues.

Summary of the issue:

Some of the GitHub references in the change log were targetting wrong issue or PR.

Description of user facing changes

The references have been fixed in the change log document.

Description of development approach

Fixed the following references:

Also, I have replaced #13276 (Libre Office issue) by #13277 (associated PR) since the issue description is not related at all with the change for developers.

Testing strategy:

Manual test: Check each change log item in the change log generated by appVeyor in this PR.

Known issues with pull request:

I have also found some PR refs even if there are associated issues. The rule is usually to reference the issue when there is one. But I have not bothered to fix it since it is easy to find the issue when you have the PR.

Additional note:

  • There have been 3 wrong references in the 2022.2 dev cycle. Maybe a checkof the ref should be added in NVAccess' protocol:
    • either check the ref just before merging a PR to master
    • or check all the refs (as I did in this PR) when you finalize the change log adding the intro text of the release

Change log entries:

None

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@AppVeyorBot
Copy link
Copy Markdown

  • PASS: Translation comments check.
  • PASS: Unit tests.
  • PASS: Lint check.
  • Build execution time has reached the maximum allowed time for your plan (60 minutes).

See test results for failed build of commit 2b1235359c

@CyrilleB79 CyrilleB79 marked this pull request as ready for review June 20, 2022 11:31
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner June 20, 2022 11:31
@CyrilleB79 CyrilleB79 requested review from seanbudd and removed request for a team June 20, 2022 11:31
@CyrilleB79

This comment was marked as off-topic.

@CyrilleB79
Copy link
Copy Markdown
Contributor Author

Also @seanbudd, @feerrenrut, please have a look at this PR before declaring translation freeze. Thanks.

@seanbudd
Copy link
Copy Markdown
Member

• Build execution time has reached the maximum allowed time for your plan (60 minutes).

This is likely a bug, and not related to the length of build times increasing.

@seanbudd seanbudd added this to the 2022.2 milestone Jun 21, 2022
@seanbudd
Copy link
Copy Markdown
Member

or check all the refs (as I did in this PR) when you finalize the change log adding the intro text of the release

I think this was missed, and needs to be added to the process.

@seanbudd seanbudd merged commit ec56c3c into nvaccess:beta Jun 21, 2022
@CyrilleB79 CyrilleB79 deleted the changeLogRefs branch June 21, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants