Update py2exe to version 0.11.0.0#13057
Merged
seanbudd merged 2 commits intonvaccess:masterfrom Nov 15, 2021
Merged
Conversation
Contributor
Author
|
I'd be nice to merge this ASAP to give it a good testing in Alpha just to be on the safe side. |
Member
|
@lukaszgo1 - here is the try build for testing https://ci.appveyor.com/api/buildjobs/nfx15r1xbqsrh7os/artifacts/output/nvda_snapshot_try-py2exe-13057-24213,15f9f2a4.exe |
Contributor
Author
|
Judging from the build log and created artifacts .appx packages can be created successfully. This is good to go to Alpha! |
seanbudd
approved these changes
Nov 15, 2021
Contributor
|
After this PR, in Notepad++: Traceback (most recent call last):
File "C:\projects\nvda\source\core.py", line 232, in _setInitialFocus
File "C:\projects\nvda\source\NVDAObjects\__init__.py", line 304, in objectWithFocus
File "C:\projects\nvda\source\NVDAObjects\__init__.py", line 92, in __call__
File "C:\projects\nvda\source\NVDAObjects\IAccessible\__init__.py", line 469, in findOverlayClasses
File "C:\Python37\lib\importlib\__init__.py", line 127, in import_module
File "<frozen importlib._bootstrap>", line 1006, in _gcd_import
File "<frozen importlib._bootstrap>", line 983, in _find_and_load
File "<frozen importlib._bootstrap>", line 965, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'NVDAObjects.IAccessible.scintilla'Notably, I have no "c:\projects\NVDA" on my machine... |
This comment has been minimized.
This comment has been minimized.
Member
|
@codeofdusk I can confirm this issue - very strange. Reverting this PR |
seanbudd
added a commit
that referenced
this pull request
Nov 16, 2021
seanbudd
pushed a commit
that referenced
this pull request
Nov 18, 2021
Closes #12357 Summary of the issue: NVDA currently uses py2exe version 0.10.1.0 to create a binary version since never versions of py2exe causes errors during build (py2exe/py2exe#112). These errors has been fixed by @albertosottile in version 0.11.0.0. While never version of py2exe does not provide us with any advantages for now not upgrading regularly might make it difficult to do so when we would need to move to Python 3.10 or later (currently used version of py2exe supports only up to 3.9). Description of how this pull request fixes the issue: Updates version of py2exe we're using to 0.11.0.1 Testing strategy: Created a self signed launcher - made sure that NVDA functions well in general Tested that NVDA_eoaproxy works Smoke tested NVDA-dmp and NVDA_slave Ensured that correct file names are shown in tracebacks ((see Update py2exe to version 0.11.0.0 #13057) Ensured that entire content of NVDAObjects package is included in the library.zip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #12357
Summary of the issue:
NVDA currently uses py2exe version 0.10.1.0 to create a binary version since never versions of py2exe causes errors during build (py2exe/py2exe#112). These errors has been fixed by @albertosottile in version 0.11.0.0. While never version of py2exe does not provide us with any advantages for now not upgrading regularly might make it difficult to do so when we would need to move to Python 3.10 or later (currently used version of py2exe supports only up to 3.9).
Description of how this pull request fixes the issue:
Updates version of py2exe we're using to 0.11.0.0
Testing strategy:
Known issues with pull request:
A try branch should be created from this one before it is merged so that we can ensure that .appx package can be created.
Change log entries:
For Developers
Code Review Checklist: