Convert NVDA's code base to use output reasons from enum in controlTypes and remove deprecated REASON_* module level constants#11969
Merged
michaelDCurran merged 5 commits intoJan 26, 2021
Conversation
Contributor
Author
|
@feerrenrut As I've predicted in the PR description due to the amount of modified files this had conflicts already. Would it be possible to review this to avoid multiple back and forth of fixing merge conflicts here? |
Contributor
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@feerrenrut This PR merely starts using enum added in #10703 so I believe consistency should not be an issue. In deed |
michaelDCurran
approved these changes
Jan 26, 2021
CyrilleB79
added a commit
to CyrilleB79/nvda
that referenced
this pull request
Jan 27, 2021
AAClause
added a commit
to AAClause/BrailleExtender
that referenced
this pull request
Jan 29, 2021
AAClause
added a commit
to AAClause/BrailleExtender
that referenced
this pull request
Jan 29, 2021
michaelDCurran
pushed a commit
that referenced
this pull request
Jan 31, 2021
michaelDCurran
added a commit
that referenced
this pull request
Feb 2, 2021
michaelDCurran
added a commit
that referenced
this pull request
Feb 3, 2021
AAClause
added a commit
to AAClause/BrailleExtender
that referenced
this pull request
Feb 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Discussion in #10703 and #10732
Summary of the issue:
PR #10703 introduced new
OutputReasonclass which should be used in place of previously usedREASON_*constants from thecontrolTypesmodule. To provide backward compatibility old module level constants were kept in place, but marked as deprecated. Since 2021.1 intents to break backwards compatibility anyway it makes sense to use output reasons from the new enum throughout the code and remove these deprecated constants.Description of how this pull request fixes the issue:
This pr converts all usages of
REASON_*constants to the new enum (git grep was used to look for all occurrences of them) and removes old constants from thecontrolTypesandbrowseModemodules.Testing performed:
REASON_in the code is in the changelog fileKnown issues with pull request:
I'd be great to merge this soon not only to give it a good amount of testing on Alpha, but it touches many files and therefore is quite prone to conflicts.
Change log entry:
Changes for developers:
REASON_*constants are removed fromcontrolTypes- please usecontrolTypes.OutputReasoninstead.REASON_QUICKNAVhas been removed frombrowseMode- usecontrolTypes.OutputReason.QUICKNAVinstead