Skip to content

Fix up #11969: Fixed case issue.#12015

Merged
michaelDCurran merged 1 commit into
nvaccess:masterfrom
CyrilleB79:fixUp11969)
Jan 31, 2021
Merged

Fix up #11969: Fixed case issue.#12015
michaelDCurran merged 1 commit into
nvaccess:masterfrom
CyrilleB79:fixUp11969)

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #12014
Fixes #12013
Fix-up of #11969

Summary of the issue:

In #11969, a typo has been introduced: "Focus" (title case) instead of "FOCUS" (upper case)

Description of how this pull request fixes the issue:

Fixed the typo

Testing performed:

Called NVDA+F where I have also seen this issue.

Known issues with pull request:

None

Change log entry:

None: fix-up in alpha stage.

@lukaszgo1

Copy link
Copy Markdown
Contributor

@CyrilleB79 Many thanks for cleaning my mess :-)

@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit 4a8c35b4ef

@CyrilleB79

Copy link
Copy Markdown
Contributor Author

The system tests has failed. However, I do not know why.
Any idea from someone else?

@lukaszgo1

Copy link
Copy Markdown
Contributor

I don't think system test failure is related to your changes - this particular test simply fails intermittently.

@michaelDCurran

Copy link
Copy Markdown
Member

When reviewing this time, I confirmed with grep that there are no other references to OutputReason members containing lowercase.: "OutputReason.[a-zA-Z]*[a-z]"

@michaelDCurran michaelDCurran merged commit 94e2926 into nvaccess:master Jan 31, 2021
@nvaccessAuto nvaccessAuto added this to the 2021.1 milestone Jan 31, 2021
@CyrilleB79 CyrilleB79 deleted the fixUp11969) branch February 1, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When page in google chrome is opened, the errors start to appear Attribute error breaks automatic say all in Mozilla apps

5 participants