Fix up of #11969: correct logic for heading levels in getFormatfieldSpeech#12026
Merged
Conversation
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Summary of the issue:
In pr #11969 REASON_* constants were replaced with OutputReason.* enum constants.
However, a logic error was introduced in speech.getFormatFieldSpeech which caused NVDA to no longer be able to read content in edgeHTML (Edge classic) documents. Causing the following exception:
This is due to the
being moved out of its original brackets and into a new set of outer brackets.
Description of how this pull request fixes the issue:
Moves the code back into the original place, maintaining linting rules.
Testing performed:
Did a search in the start screen, and arrowed down into the extra content (which is an Edge classic document). Previusly this caused an exception. Now all the content reads again.
Known issues with pull request:
None.
Change log entry:
None.