Ugh, I"m sorry for going so wild on my keyboard

Sorry for being so brutal, but I think that in the future something needs to be done, so that NVDA can automatically discover liblouis tables. Now we have a problem in which we need to do this manually for every table, which is not so good.

I think you're not brutal at all but bringing up a fair point. There's an issue for that, see #11298
There is #290 as well, which is slightly related.

1. Why is input disabled for the russian tables? I think it would be good to have a rationale in a comment.

I simply used provided metadata to add these tables:

(0)$ cat ru-litbrl.ctb | grep "#+"
#+locale: ru
#+type: literary
#+dots: 6
#+contraction: no
#+direction: forward
(0)$ cat ru-litbrl-detailed.utb|grep "#+"
#+locale: ru
#+type: literary
#+dots: 6
#+contraction: no
#+direction: forward
#+variant: detailed
(0)$ 

Any thought @Futyn-Maker?

2. Given this release fixes two issues related to crashes and doesn't contain many additional changes to the core, I think we should consider shipping this with 2020.4. The beta period should be long enough to revert if it really breaks.

👍

Hello contributers! I was waiting for this PR. The couple of words about Russian tables:

1. At the moment I'm not ready to develop the back translation according to rules of the Russian literary braille, it's quite difficult, so this table only for reading now, it's all right.
2. I recommend to add all tables - ru-litbrl.ctb and ru-litbrl-detailed.utb to provide user's choice.

Andrey

I also would like to know if it is possible to replace "grade 1" with "literary braille" in the UI, or it can be done separate for the Russian localization. The reason is that we don't use contracted braille almost at all, so names "computer braille" and "literary braille" can be more understandable for end users than "grade 1", because there's no any gradation in fact. But it's not super important. @zstanecic do You have any comments about it?

Thanks. As for me, looks good.

Added milestone 2020.4 for @feerrenrut or @michaelDCurran to triage.

@zstanecic In my opinion, Leonard should have added this braille table in #11537.
Although I think it's out of scope for this PR, I am in favor of adding it. Should we make another pull request?

Changelog entry for this one should probably mention the newly added tables.

I support merging this into 2020.4, so that the NVDA and Liblouis stable versions become once again in sync.

If we want this in 2020.4, it will need to be retargeted to beta

• System test failure
• Build (for testing PR)

See test results for failed build of commit f5fde1895e