Update liblouis to version 3.15.0#11537
Merged
Merged
Conversation
Contributor
|
As the part of this release, please add Coptic tables.
|
Contributor
|
Hi, there has been requests to add more tables, which should be discussed in a separate issue that will be tied to this PR if needed. Thanks.
|
Collaborator
Author
|
I think it would be good to leave this pr as is, and provide a follow up pr with additional tables, thereby following the naming guidelines from the liblouis project. |
Contributor
|
Maybe consider including this PR (without tables) in 2020.3, and push the new tables to 2020.4? Therefore the Liblouis version won't lag behind the next NVDA release. |
Contributor
|
Hi, it’s a bit risky, especially as we don’t want to go through regressions like a few years ago. Thanks.
|
feerrenrut
previously approved these changes
Sep 3, 2020
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
As suggested, this will target 2020.4
feerrenrut
approved these changes
Sep 9, 2020
dawidpieper
pushed a commit
to dawidpieper/nvda
that referenced
this pull request
Sep 13, 2020
Co-authored-by: Reef Turner <reef@nvaccess.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note, aiming at NVDA 2020.4
Link to issue number:
None
Description of this pull request
Updates liblouis to 3.15.0, which is a minor release with some table improvements.
Testing performed:
T.b.d.
Known issues with pull request:
None
Change log entry: