Revert "Add appModule for Visual Studio Code Insiders"#10903
Conversation
|
Hi, I think it might be advisable to keep the Insider version around just in case we need to resolve future accessibility issues/mitigate issues that would show up in future Insider releases. Thanks.
|
|
To clarify This appModule was created to avoid enabling browse mode by default in VS Code Insiders. Effort has been put in improving the overall experience of vs code, in particular the alerts are now part of the application container.
The only thing that this appModule does is disabling browse mode by default. Note that we can also do this on configuration profile level. Therefore, I second this pull request. |
LeonarddeR
left a comment
There was a problem hiding this comment.
Could you please change the target branch to beta. I think that it makes sense to revert this from beta so this won't be in 2020.1 and will be out in 2020.2 again.
There's also a whats new entry that has to be removed, though I leave it up to @michaelDCurran to decide whether that has to be done in this pr or in a subsequent manual commit.
Sorry, I tried doing that through the Github UI, and suddenly that added all kinds of commits by other people to this PR. And I have no idea what happened, or why it did that, but I feel this is not what was the intended outcome. 🤯 |
This reverts commit 3ba1f46.
This reverts commit 480950f. Removes the no-longer needed code.py appmodule. Follow up of #10903 (removed the no-longer needed code - insiders.py appmodule) Reverts #9828 (creating the code.py appmodule) Changes to VS Code fixing #10888 have now made it stable. Therefore, remove the appModule which worked around these issues. Note: Users can continue to force disable browse mode by default using a profile automatically triggered when entering vsCode that unchecks "Enable browse mode on page load" on the browse mode settings panel.
Reverts #10858. Fixes #10888 for VS Code insider builds now that microsoft/vscode#93087 is fixed.