Skip to content

Revert appModule for VS Code to disable browse mode by default#10921

Merged
feerrenrut merged 1 commit into
masterfrom
revert-9828-vsCode
Apr 30, 2020
Merged

Revert appModule for VS Code to disable browse mode by default#10921
feerrenrut merged 1 commit into
masterfrom
revert-9828-vsCode

Conversation

@LeonarddeR

@LeonarddeR LeonarddeR commented Mar 31, 2020

Copy link
Copy Markdown
Collaborator

This PR removes the no-longer needed code.py appmodule.

Related issues

Fixes #10888
Follow up of #10903 (removed the no-longer needed code - insiders.py appmodule)
Reverts #9828 (creating the code.py appmodule)

Description

Changes to VS Code fixing #10888 have now made it stable.
Therefore, remove the appModule which worked around these issues.
Note: Users can continue to force disable browse mode by default using a profile automatically triggered when entering vsCode that unchecks "Enable browse mode on page load" on the browse mode settings panel.

Changelog entry

@LeonarddeR LeonarddeR marked this pull request as ready for review April 9, 2020 13:31
@LeonarddeR

Copy link
Copy Markdown
Collaborator Author

VSCode 1.44 is now out, which contains the needed fixes.

@feerrenrut feerrenrut merged commit e095f81 into master Apr 30, 2020
@feerrenrut feerrenrut deleted the revert-9828-vsCode branch April 30, 2020 13:56
@nvaccessAuto nvaccessAuto added this to the 2020.1 milestone Apr 30, 2020
feerrenrut added a commit that referenced this pull request Apr 30, 2020
@feerrenrut feerrenrut modified the milestones: 2020.1, 2020.2 Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VS Code: Reduce the number of times one has to use NVDA+Space to switch modes.

3 participants