Add appModule for Visual Studio Code Insiders#10858
Merged
Merged
Conversation
See test results for failed build of commit f6876459b5 |
michaelDCurran
approved these changes
Mar 9, 2020
michaelDCurran
added a commit
that referenced
this pull request
Mar 9, 2020
michaelDCurran
pushed a commit
that referenced
this pull request
Mar 31, 2020
michaelDCurran
added a commit
that referenced
this pull request
Apr 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #10853
Summary of the issue:
Visual Studio Code Insiders is a special version of Code with bleeding edge features. The appModule for Code that disables browse mode by default doesn't work in the Insiders variant.
Description of how this pull request fixes the issue:
Add an appModule for insiders that imports the regular appModule.
Testing performed:
Tested that browse mode stays off by default in VS Code Insiders.
Known issues with pull request:
This imports the code appModule from builtIN appModules. I wonder whether we should use
from appModules.code import AppModuleinstead. Thoughts anyone?Change log entry: